[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800
+33
−165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @targos in #60429 (comment), the implementation of
total_allocated_byteschanges the ABI. This PR changes original V8 implementation to a version where there's no addition ofHeapStatistics::total_allocated_bytes_to V8'sHeapStatistics, and instead we get such values usingIsolate::GetTotalAllocatedBytes. This also changes code introduced by #60573 to use this new API on eitherv8.getHeapStatistics()andWorker::GetHeapStatistics. The goal here is to maketotal_allocated_bytesback portable to previous versions, but keeping thev8.getHeapStatistics()API stable once users transition from v25 to future versions. It also solves the ABI change introduced by https://github.com/nodejs/node/pull/60429/filesThere's also a fix on documentation text with missing
.and updating the code snippet to includetotal_allocated_byteson output.